Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 10 and 12. Add 16 and 18 #561

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Dec 10, 2022

Might require a major version bump? Is the changelog just created manually?

The CI is failing on it due to outdated Node versions. This should fix it
node-sass wouldn't install because it was too old
magic-string was causing a deprecation warning
I was getting an error from husky. I'm not sure if upgrading it helped, but hopefully it doesn't hurt

@kaisermann
Copy link
Member

Hey, @benmccann 👋 Thanks! I will take care of this! The changelog is written automatically when publishing via the conventional-changelog CLI.

Might require a major version bump?

Yeah, it does. Better to be on the safe side here.

@kaisermann
Copy link
Member

kaisermann commented Dec 10, 2022

I'm getting some weird, possibly node-gyp related, when trying to install the project's deps with node-sass@8. (was on main accidentally 😅 ) Given that changing the node requirement already implies in a breaking change, we could look into just supporting sass and removing support for node-sass and some point.

(deprecation notice for node-sass: sass/node-sass#2952)

I'm going to merge this onto the v5 branch but the discussion can continue here: #562

@kaisermann kaisermann changed the base branch from main to v5 December 10, 2022 09:56
@kaisermann kaisermann merged commit 55c051d into sveltejs:v5 Dec 10, 2022
@kaisermann kaisermann self-assigned this Dec 10, 2022
kaisermann pushed a commit that referenced this pull request Dec 10, 2022
* Drop Node 10 and 12. Add 16 and 18
* Upgrade a couple dependencies

BREAKING CHANGE: minimum node version changed to v14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants