fix: improve unowned derived performance (#14724)

* fix: improve unowned derived performance * fix: improve unowned derived performance * changeset
sveltejs · Dec 16, 2024 · 699dc6e · 699dc6e
1 parent bbf3829
commit 699dc6e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/many-worms-attend.md b/.changeset/many-worms-attend.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: improve unowned derived performance
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -230,8 +230,9 @@ export function check_dirtiness(reaction) {
 			}
 		}
 
-		// Unowned signals should never be marked as clean.
-		if (!is_unowned) {
+		// Unowned signals should never be marked as clean unless they
+		// are used within an active_effect without skip_reaction
+		if (!is_unowned || (active_effect !== null && !skip_reaction)) {
 			set_signal_status(reaction, CLEAN);
 		}
 	}