Skip to content

Commit

Permalink
fix: avoid relying on Node specifics within compiler (#14314)
Browse files Browse the repository at this point in the history
fixes #14294
  • Loading branch information
dummdidumm authored Nov 15, 2024
1 parent 1f0700f commit 94471ca
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/strange-adults-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: avoid relying on Node specifics within compiler
16 changes: 12 additions & 4 deletions packages/svelte/src/compiler/validate-options.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import process from 'node:process';

/** @import { ModuleCompileOptions, ValidatedModuleCompileOptions, CompileOptions, ValidatedCompileOptions } from '#compiler' */
import * as e from './errors.js';
import * as w from './warnings.js';
Expand All @@ -13,9 +11,19 @@ import * as w from './warnings.js';
const common = {
filename: string('(unknown)'),

// default to process.cwd() where it exists to replicate svelte4 behavior
// default to process.cwd() where it exists to replicate svelte4 behavior (and make Deno work with this as well)
// see https://github.com/sveltejs/svelte/blob/b62fc8c8fd2640c9b99168f01b9d958cb2f7574f/packages/svelte/src/compiler/compile/Component.js#L211
rootDir: string(typeof process !== 'undefined' ? process.cwd?.() : undefined),
/* eslint-disable */
rootDir: string(
typeof process !== 'undefined'
? process.cwd?.()
: // @ts-expect-error
typeof Deno !== 'undefined'
? // @ts-expect-error
Deno.cwd()
: undefined
),
/* eslint-enable */

dev: boolean(false),

Expand Down

0 comments on commit 94471ca

Please sign in to comment.