Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte 5 accessors broken after svelte@5.0.0-next.96 #11228

Closed
yanick opened this issue Apr 18, 2024 · 0 comments · Fixed by #11231
Closed

svelte 5 accessors broken after svelte@5.0.0-next.96 #11228

yanick opened this issue Apr 18, 2024 · 0 comments · Fixed by #11231
Milestone

Comments

@yanick
Copy link

yanick commented Apr 18, 2024

Describe the bug

It's probably already known and/or in flux, but just in case it can be of help: changing parameters via accessors was working fine up to svelte@5.0.0-next.96 (using https://github.com/testing-library/svelte-testing-library/blob/main/src/__tests__/rerender.test.js), when at version100 began to die hard with

 FAIL  src/__tests__/rerender.test.js [ src/__tests__/rerender.test.js ]
TypeError: Cannot read properties of undefined (reading 'source')
 ❯ Module.hmr node_modules/.pnpm/svelte@5.0.0-next.97/node_modules/svelte/src/internal/client/dev/hmr.js:16:11
     16|  }
     17| 
     18|  return (data.wrapper ??= /** @type {Component} */ (
       |       ^
     19|   (anchor, props) => {
     20|    let instance = {};

then at version 101 and up stop dying (yay!), but doesn't change the params anymore (sad panda).

Reproduction

git clone https://github.com/testing-library/svelte-testing-library
cd svelte-testing-library
pnpm install
pnpm add svelte@next
vitest src/__tests__/rerender.test.js

Logs

No response

System Info

See, e.g., https://github.com/testing-library/svelte-testing-library/actions/runs/8741149959/job/23986502306

Severity

annoyance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants