We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's probably already known and/or in flux, but just in case it can be of help: changing parameters via accessors was working fine up to svelte@5.0.0-next.96 (using https://github.com/testing-library/svelte-testing-library/blob/main/src/__tests__/rerender.test.js), when at version100 began to die hard with
FAIL src/__tests__/rerender.test.js [ src/__tests__/rerender.test.js ] TypeError: Cannot read properties of undefined (reading 'source') ❯ Module.hmr node_modules/.pnpm/svelte@5.0.0-next.97/node_modules/svelte/src/internal/client/dev/hmr.js:16:11 16| } 17| 18| return (data.wrapper ??= /** @type {Component} */ ( | ^ 19| (anchor, props) => { 20| let instance = {};
then at version 101 and up stop dying (yay!), but doesn't change the params anymore (sad panda).
git clone https://github.com/testing-library/svelte-testing-library cd svelte-testing-library pnpm install pnpm add svelte@next vitest src/__tests__/rerender.test.js
No response
See, e.g., https://github.com/testing-library/svelte-testing-library/actions/runs/8741149959/job/23986502306
annoyance
The text was updated successfully, but these errors were encountered:
fix: preserve getters/setters in HMR mode
1e8c455
fixes #11228
fix: preserve getters/setters in HMR mode (#11231)
669d2d7
Successfully merging a pull request may close this issue.
Describe the bug
It's probably already known and/or in flux, but just in case it can be of help: changing parameters via accessors was working fine up to svelte@5.0.0-next.96 (using https://github.com/testing-library/svelte-testing-library/blob/main/src/__tests__/rerender.test.js), when at version100 began to die hard with
then at version 101 and up stop dying (yay!), but doesn't change the params anymore (sad panda).
Reproduction
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: