Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply directives in order #2446

Closed
Rich-Harris opened this issue Apr 20, 2019 · 1 comment · Fixed by #4156
Closed

Apply directives in order #2446

Rich-Harris opened this issue Apr 20, 2019 · 1 comment · Fixed by #4156
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Currently, on:input event handlers are applied before any event handlers from actions or bindings, regardless of the order in which they're declared. This makes certain tasks (such as input masking) overly difficult.

Demos (which behave differently between Chrome and Firefox):

A solution would be to consistently apply directives in the order in which they're declared. It'll require some rejiggering though.
@Rich-Harris Rich-Harris added this to the 3.x milestone Apr 20, 2019
colincasey pushed a commit to colincasey/svelte that referenced this issue May 10, 2019
@colincasey-sfdc
sveltejs#2446 - apply directives in order
6f491a5
@mrkishi mrkishi mentioned this issue May 11, 2019
Closed
colincasey pushed a commit to colincasey/svelte that referenced this issue May 11, 2019
@colincasey-sfdc
sveltejs#2446 - apply directives in order
2b2dd8e
colincasey added a commit to colincasey/svelte that referenced this issue May 11, 2019
@colincasey
FIX sveltejs#2446: apply bindings and event handlers in order
4172406
@colincasey colincasey mentioned this issue May 11, 2019
Closed
@Conduitry Conduitry mentioned this issue Sep 9, 2019
Closed
tanhauhau pushed a commit to tanhauhau/svelte that referenced this issue Dec 23, 2019
@colincasey @tanhauhau
FIX sveltejs#2446: apply bindings and event handlers in order
da663da
@Conduitry
Copy link
Member

Re-opening this. The second example works well (for me, in Firefox) now in 3.16.6 - but the first one isn't. I'm still getting lower-case letters. The action works properly if the bind: is removed. Do we also need to update how we're applying actions? cc @tanhauhau

@Conduitry Conduitry reopened this Dec 23, 2019
@tanhauhau tanhauhau mentioned this issue Dec 24, 2019
Merged
@tanhauhau tanhauhau mentioned this issue Mar 1, 2020
Merged
taylorzane pushed a commit to taylorzane/svelte that referenced this issue Dec 17, 2020
@colincasey @taylorzane
FIX sveltejs#2446: apply bindings and event handlers in order
dfc6b66
@Conduitry Conduitry mentioned this issue Apr 14, 2021
Closed
@ITenthusiasm ITenthusiasm mentioned this issue Dec 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat order attributes + actions too tanhauhau/svelte
2 participants
@Rich-Harris @Conduitry