Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump axobject-query #10167

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: bump axobject-query #10167

merged 1 commit into from
Jan 15, 2024

Conversation

dummdidumm
Copy link
Member

fixes #8825

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: f86b882

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member

dominikg commented Jan 12, 2024

the changelog for axobject-query 4.0 is very short and does not indicate that it fixed handling of summary. https://github.com/A11yance/axobject-query/blob/main/CHANGELOG.md

(scroll down, 4.0 is at the bottom)

are we confident this does not introduce breaking changes or does this bump have to wait for svelte5?

edit: og issue A11yance/axobject-query#319 looks like its the DisclosureTriangleRole entry.

@benmccann
Copy link
Member

man the svelte 4 lint errors are annoying... anyone know what's causing them or if we can fix them?

@dummdidumm dummdidumm merged commit 4901029 into svelte-4 Jan 15, 2024
7 of 8 checks passed
@dummdidumm dummdidumm deleted the bump-axobject branch January 15, 2024 09:28
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants