Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that CSS is generated for the final frame of a transition #11251

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Rich-Harris
Copy link
Member

fixes #11081. No test because it doesn't reproduce in our test suite — I added a comment instead that is hopefully clear enough to prevent careless regressions

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: 9439e7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

self-merging since this is a fairly trivial change

@Rich-Harris Rich-Harris merged commit 6bff8c0 into main Apr 19, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the gh-11081 branch April 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 doesn't produce the last tween value in transitions
1 participant