fix: consider variables with synthetic store sub as state #14195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4f30961 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-14195-svelte.vercel.app/ this is an automated message |
|
dummdidumm
reviewed
Nov 7, 2024
dummdidumm
reviewed
Nov 7, 2024
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
paoloricciuti
commented
Nov 7, 2024
packages/svelte/tests/migrate/samples/effects-with-alias-run/output.svelte
Outdated
Show resolved
Hide resolved
dummdidumm
approved these changes
Nov 7, 2024
Merged
kyoshino
added a commit
to sveltia/sveltia-cms
that referenced
this pull request
Nov 9, 2024
Probably due to sveltejs/svelte#14195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14183
This made also change one migration because we were accessing a variable as a store and it's now considered state.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint