Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add <svelte:html> element #14397

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add <svelte:html> element #14397

wants to merge 2 commits into from
+232 −10

Conversation

dummdidumm
Copy link
Member

closes #8663

needs a companion PR in SvelteKit

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5ba013e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14397-svelte.vercel.app/

this is an automated message

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14397

@Leonidaz
Copy link

Nice! works as expected.

one minor issue that I noticed in the playground, if you add an attribute and then erase it from the code, the attribute stays in the <html>, unless you set the attribute to undefined and then it's removed.

@dummdidumm
Copy link
Member Author

that sounds like something we need to specifically handle in the playground/during hmr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add <svelte:html> special element
3 participants
@dummdidumm @Rich-Harris @Leonidaz