Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compare array contents for equality mismatch detections, not the arrays themselves #14738

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Rich-Harris
Copy link
Member

Fixes #14705, alternative to #14729

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: c0facdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14738


if (test !== -1) {
w.state_proxy_equality_mismatch('array.indexOf(...)');
for (let i = from_index ?? 0; i < this.length; i += 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this check as the others that use it be only done in DEV? Seems kind of wasteful to do in production if an item legitimately doesn't exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only done in dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! oops, sorry, missed that this is all inside init_array_prototype_warnings 🤦‍♂️ which is only called in DEV

@Rich-Harris Rich-Harris merged commit 36a437c into main Dec 17, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the gh-14705 branch December 17, 2024 18:04
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: state_proxy_equality_mismatch when checking Array.prototype.includes after emptying the array
3 participants