Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hoist non-renamed exports #2351

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Don't hoist non-renamed exports #2351

merged 2 commits into from
Apr 6, 2019

Conversation

jches
Copy link
Contributor

@jches jches commented Apr 2, 2019

Non-renamed exports initialized with a literal were being hoisted, leading to a $$props reference outside the component instance.

let name = 'world';
	
export { name };

$$props is not defined

Fixes #2347

@jches jches mentioned this pull request Apr 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #2351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2351   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c0887...cfc1a40. Read the comment docs.

@Rich-Harris Rich-Harris merged commit c20ad22 into sveltejs:master Apr 6, 2019
@Rich-Harris
Copy link
Member

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants