Update Transition Tutorial #2792
Conversation
The `fade` import was removed in the previous chapter, it needs to be re-added for the example to work correctly.
|
I don't think it's completely unreasonable to expect that people would have to also edit the imports when following a tutorial. I'm not sure what's the most pedagogically sound thing to have in the 'before' part of this page. It might be valuable to teach people here that they do have to import the transitions they want to use. |
|
It ultimately depends on whether we want to have the tutorial as a continuous flow or self-contained into sections or even individual lessons. |
|
This missing import stood out to me because this exercise was the only one that could not be completed by following the instructions only. You needed to know where to grab the I like the fact that each exercise in the tutorial can be completed by just following the instructions. This one just felt inconsistent with the rest of them. |
|
I agree with that point, but I think the fix is to make the instructions more explicit, so I've done that: 0d7f6fb Will close this PR, thank you |
* master: (87 commits) -> v3.4.3 always add raw property to text nodes flesh out in/out transition tutorial chapter (sveltejs#2792) code style fix test fix tests Fix CRUD example to allow changing input values. Fixes sveltejs#2714 treat requestAnimationFrame as a noop on the server site: actions tutorial: destroy is not required (sveltejs#2776) Allow binding of <details> open site: add /faq redirect to GitHub wiki FAQ fix case sensitive import name, improve tsconfig type declarations for bundled files convert everything to TypeScript check for unknown props when creating component cleanup, improve comments typecheck npm script workarond for estree-walker related typings conflict compile/render-dom and other remaining typings ... # Conflicts: # src/compile/render-dom/wrappers/Element/index.ts
…ings * master: (66 commits) -> v3.4.3 always add raw property to text nodes flesh out in/out transition tutorial chapter (sveltejs#2792) code style fix test fix tests Fix CRUD example to allow changing input values. Fixes sveltejs#2714 treat requestAnimationFrame as a noop on the server site: actions tutorial: destroy is not required (sveltejs#2776) Allow binding of <details> open site: add /faq redirect to GitHub wiki FAQ fix case sensitive import name, improve tsconfig type declarations for bundled files convert everything to TypeScript check for unknown props when creating component cleanup, improve comments typecheck npm script workarond for estree-walker related typings conflict compile/render-dom and other remaining typings ...
Description
I was following the Tutorial and I've noticed this really minor missing piece. The
fadeimport was replaced withflyin exercise 10.b, but it needs to be re-added for 10.c to work correctly.