Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Document svelte/easing #3292

Merged
merged 9 commits into from
Jul 26, 2019
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jul 26, 2019

This PR documents svelte/easing and adds an ease visualiser to the examples section.

There doesn't really seem to be a way to add interactive widgets to the Docs without making some changes so, as discussed previously, I've added it to the examples section. I updated the relevant section in the API reference, adding a link to the visualiser and a brief overview of all of the functions exported from that module.

The only significant issue is the fact that the 3-panel display makes the preview window quite small on first load. I've worked around this partly by making the visualiser mobile friendly (ish). It isn't friendly to all device sizes and widths but it seems to work fine on desktop and mobile (portrait).

There are a lot of changes in this PR because I had to update half of the folder names in content/examples to get the easing example in the right slot (I put it just after animations).

Closes #2537.

Edit: Github is rendering my tabs all weird and I don't know why. I'm pretty sure I'm using the same indentation everywhere, I've even quadruple checked. No clue.

@Conduitry
Copy link
Member

I think my only complaint right now is that the list of the easings on the API page takes up a lot of vertical space. Is there some nicer way to arrange these into a table? I understand that this is rendered from markdown and the formatting options are limited.

@pngwn
Copy link
Member Author

pngwn commented Jul 26, 2019

The table seems better, how do you feel about this:

Screenshot 2019-07-26 at 18 49 59

Edit: Slightly cramped on mobile but not unreadable. I could lose the ease names on the left and it would probably fit more comfortably.

@Conduitry
Copy link
Member

👍 Yep definitely better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site: document svelte/easing
2 participants