hydrating static content #4297
Closed
hydrating static content #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhauhau
force-pushed
the
tanhauhau/hydrating-static-content
branch
from
a643c1d to
aa077e2
Compare
tanhauhau
force-pushed
the
tanhauhau/hydrating-static-content
branch
from
aa077e2 to
89b7cf6
Compare
tanhauhau
force-pushed
the
tanhauhau/hydrating-static-content
branch
from
89b7cf6 to
281860e
Compare
|
I'm going to close this, because we need to spend more time thinking about how we want hydration to work, and how we'll tell the compiler where it's safe to do the 'easier' hydration where we assume the starting DOM is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assuming server render content is correct, if the content is static, then can skip hydrating it's children.
.innerHtmlis used.possibly fixes: #2152
changes built on top of #4444