Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a markup parameter to Preprocessors. #4913

Closed
wants to merge 1 commit into from

Conversation

MaartenX
Copy link

@MaartenX MaartenX commented May 27, 2020

This parameter will hold the entire processed source file up until the
current preprocessor. This enables the script and style preprocessors to use context information from the entire file.

Fixes #4912

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

This parameter will hold the entire processed source file up until the
current preprocessor.

Fixes sveltejs#4912
@MaartenX MaartenX force-pushed the preprocess_markup branch from ff7269d to 17a3e28 Compare May 27, 2020 12:32
@Conduitry Conduitry closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a markup parameter to the script and style preprocessors.
2 participants