Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add a11y check on abstract roles #6241

Merged
merged 3 commits into from
Jul 11, 2022
Merged

[feat] add a11y check on abstract roles #6241

merged 3 commits into from
Jul 11, 2022

Conversation

anthonylegoas
Copy link
Contributor

This PR adds an accessibility check on abstract roles. See the wai-aria 1.1 specification for more informations. #820

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@pngwn pngwn added compiler Changes relating to the compiler and removed feature: a11y labels Jun 27, 2021
@benmccann benmccann changed the title add a11y check on abstract roles [feat] add a11y check on abstract roles Jun 30, 2021
@anthonylegoas anthonylegoas force-pushed the a11y-check-abstract-aria-roles branch from 04ea56c to 783c59a Compare August 2, 2021 14:51
@anthonylegoas anthonylegoas force-pushed the a11y-check-abstract-aria-roles branch from 783c59a to 46c5937 Compare February 9, 2022 09:31
@anthonylegoas
Copy link
Contributor Author

I rebased the branch on master.
@benmccann Is there any chance for this PR to be merged?

@benmccann
Copy link
Member

I'm really not the person to ask since I'm not that familiar with the Svelte core codebase or acessibility. Perhaps @geoffrich could take a peek at some point?

@tanhauhau tanhauhau force-pushed the a11y-check-abstract-aria-roles branch from 46c5937 to 6fd4aae Compare July 11, 2022 05:29
@tanhauhau tanhauhau merged commit f5111ef into sveltejs:master Jul 11, 2022
@Conduitry
Copy link
Member

This has been released in 3.50.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffrich geoffrich geoffrich approved these changes

@tanhauhau tanhauhau tanhauhau approved these changes

@dummdidumm dummdidumm Awaiting requested review from dummdidumm

Assignees
No one assigned
Labels
compiler Changes relating to the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anthonylegoas @benmccann @Conduitry @tanhauhau @geoffrich @pngwn