Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make changing the name of a REPL obvious #6808

Merged
merged 4 commits into from
Dec 2, 2021
Merged

[chore] Make changing the name of a REPL obvious #6808

merged 4 commits into from
Dec 2, 2021

Conversation

baseballyama
Copy link
Member

Improvement of #6797

Honestly, I also took time to know I can edit a title of REPL.
So I tried to improve it according to the issue.

[Current Version]
https://svelte.dev/repl/hello-world?version=3.43.1

[After Improvement]
https://user-images.githubusercontent.com/19153718/135877687-d2f386dc-dd01-48ec-b69d-68bbafb05817.mp4


Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Thank you!

@benmccann benmccann added the site label Oct 5, 2021
@Conduitry
Copy link
Member

How about making the edit icon only appear when hovering over the name or when it has keyboard focus? I think it's a little distracting and unsightly to have that edit icon there at all times.

@baseballyama
Copy link
Member Author

baseballyama commented Oct 12, 2021

The propose of edit icon is that tell users that the title can be modified.
But if part of the users feel little distracting and unsightly,
I think we should remove edit icon because after hover / focus on title input, already users knows it can be edit.

This PR makes it easier for users to notice that the title can be edited, so from this point of view, it may be better to do without edit icon.

Copy link
Member

@tanhauhau tanhauhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@benmccann
Copy link
Member

I'm a bit confused. The video shows an icon, but I see only one file edited and it doesn't appear to be adding an icon. Is the video in the PR description outdated? What does this look like now?

@benmccann
Copy link
Member

Ok, I see, this is just the hover. I think the size of the input on hover is a bit unsightly, but I'll go ahead and merge this since it's got a couple approvals because it's still an improvement and I don't want it to get lost in migrating things over to https://github.com/sveltejs/sites. It wouldn't be bad to add a max-width or something to the input in a follow up

@benmccann benmccann merged commit f647adf into sveltejs:master Dec 2, 2021
@baseballyama
Copy link
Member Author

OK!
I'll keep this in mind. And I will consider it after the migration is done.

@baseballyama baseballyama deleted the chore/6797-site branch December 3, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants