-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Make changing the name of a REPL obvious #6808
Conversation
How about making the edit icon only appear when hovering over the name or when it has keyboard focus? I think it's a little distracting and unsightly to have that edit icon there at all times. |
The propose of edit icon is that tell users that the title can be modified. This PR makes it easier for users to notice that the title can be edited, so from this point of view, it may be better to do without edit icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I'm a bit confused. The video shows an icon, but I see only one file edited and it doesn't appear to be adding an icon. Is the video in the PR description outdated? What does this look like now? |
Ok, I see, this is just the hover. I think the size of the input on hover is a bit unsightly, but I'll go ahead and merge this since it's got a couple approvals because it's still an improvement and I don't want it to get lost in migrating things over to https://github.com/sveltejs/sites. It wouldn't be bad to add a |
OK! |
Improvement of #6797
Honestly, I also took time to know I can edit a title of REPL.
So I tried to improve it according to the issue.
[Current Version]
https://svelte.dev/repl/hello-world?version=3.43.1
[After Improvement]
https://user-images.githubusercontent.com/19153718/135877687-d2f386dc-dd01-48ec-b69d-68bbafb05817.mp4
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint
Thank you!