-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add enableSourcemap option #6835
Conversation
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing in strings to enable just CSS or just JS sourcemaps feels like a weird API to me. I think I'd prefer passing either a boolean (which controls everything) or an object with css
and js
keys which can have boolean values.
That was actually the initial proposal and I derailed from there 😅 Updated with the |
Supersedes #6744
Part of the fix for sveltejs/kit#720
This allows us to control the generation of sourcemaps for
compile
. This is non-breaking. Implementation-wise is quite simple and doesn't provide too much perf boost. The idea is to achieve #6744 but in a more generic way.Option type:
Note: This new option was discussed in the last maintainer's meeting (suggested by @lukeed), the plan is to have
vite-plugin-svelte
disable CSS sourcemaps for SSR only to fix sveltejs/kit#720.Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint