Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] binding member expression should only invalidate the object, not the member property #7008

Merged
merged 5 commits into from
Jan 6, 2022

Conversation

tanhauhau
Copy link
Member

Fixes #6921

Previously when binding a member expression a[b][c], Svelte will invalidate all a, b, c whenever the bound value changes.

with the fix, Svelte will only invalidate a.

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

@tanhauhau I've fixed the TypeScript issue so that the project can build and the tests run, but now a lot of tests seem to be failing.

@Conduitry Conduitry marked this pull request as draft December 13, 2021 14:55
@tanhauhau tanhauhau marked this pull request as ready for review December 14, 2021 13:27
@Conduitry Conduitry merged commit 9f2b5af into sveltejs:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop with keyed each loop and bind:this
2 participants