-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] rendering void tag for <svelte:element>
#7453
Conversation
@baseballyama usually when there's new commit on the master branch, I dont merge master into my branch, instead i rebase my branch onto the latest master branch. This allows me to have a cleaner, linear history on the branch, and allowing me to squash all the changes during merging the PR. |
OK, I will use rebase on Svelte repository. Since now I did not use rebasing on Svelte after starting PR, because it become unable to know where is a new change, and I felt that merging was often used in sveltejs repositories. |
Thank you for updating it! |
I rebased it on master branch because conflict is there. |
fix: #7449
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint