update missing options.target from dev error (#753) #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As someone who's never been burned by this behavior in prod mode, I feel like this should stay a dev-mode-only error. As far as I can tell, when dev mode's off, we don't currently generate any |
|
I hadn't actually noticed the dev mode option until now (I've got to go study the docs apparently), and I was surprised by the number of warnings in our app when I turned it on. Still, I would tend to agree with @Conduitry at the moment. |
|
|
cool. closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #753. It turns out we're already throwing an error if
options.targetis missing, but only in dev mode.So I'm in two minds about whether to upgrade it. One the one hand, this is exactly what dev mode is for — adding these kinds of errors without bulking out generated code in production. On the other, you can end up with some fairly surprising bugs if you're not in dev mode.
Interested to hear what people think.