Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] update port in "Svelte for new developers" blog. #7697

Merged
merged 2 commits into from
Jul 19, 2022
Merged

[docs] update port in "Svelte for new developers" blog. #7697

merged 2 commits into from
Jul 19, 2022

Conversation

Mlocik97
Copy link
Contributor

@Mlocik97 Mlocik97 commented Jul 18, 2022 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Mlocik97 Mlocik97 changed the title Update 2019-04-16-svelte-for-new-developers.md [docs] update port in "Svelte for new developers" blog. Jul 18, 2022
geoffrich
geoffrich approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@geoffrich geoffrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vite 3 changed the default port to 5173.

@dummdidumm dummdidumm merged commit 52f5005 into sveltejs:master Jul 19, 2022
@Mlocik97 Mlocik97 deleted the patch-1 branch July 19, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffrich geoffrich geoffrich approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mlocik97 @benmccann @geoffrich @dummdidumm