Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forced production options #9

Closed
dominikg opened this issue Mar 22, 2021 · 0 comments · Fixed by #41 or #43
Closed

remove forced production options #9

dominikg opened this issue Mar 22, 2021 · 0 comments · Fixed by #41 or #43
Labels
enhancement New feature or request
Milestone

Comments

@dominikg
Copy link
Member

Describe the feature
Allow use of emitCss: false / compilerOptions.css: true for production builds

A Usecase
It has been brought up by @rixo and also reported on svite repo svitejs/svite#13
So there are usecases for this.

Alternatives
What could be alternative ways to make it happen

Additional context
We should document that emitCss is highly recommended for regular production apps

@dominikg dominikg added the enhancement New feature or request label Mar 22, 2021
@dominikg dominikg added this to the 1.0.0 milestone Mar 22, 2021
Rich-Harris added a commit that referenced this issue May 10, 2021
dominikg added a commit that referenced this issue May 10, 2021
* respect user emitCss option - fixes #9

* ensure hmr keeps working with emitCss: false option, remove forced values for css and hydratable

* add changeset

* stabilize hmr test

* stabilize hmr test some more

Co-authored-by: dominikg <dominik.goepel@gmx.de>
Conduitry pushed a commit to Conduitry/sveltejs_vite-plugin-svelte that referenced this issue May 9, 2024
…as svelte preprocessor (sveltejs#9)

* wip: prototype implmenentation of a svelte style preprocessor using vites css transform

* wip: cleanup code, ensure injectCss: false is passed, add option

* wip: add typescript preprocessor to vite preprocess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant