Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@svelteui/core]: Added Table component #456

Closed
wants to merge 5 commits into from
Closed

[@svelteui/core]: Added Table component #456

wants to merge 5 commits into from

Conversation

1yne
Copy link
Contributor

@1yne 1yne commented Sep 2, 2023

Description

Before submitting the PR, please make sure you do the following

  • Read the Contributing guide
  • Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
  • Include a description of the changes made in the PR description and in the commit messages.
  • Include screenshots/videos of the changes made.
  • Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

Adds a Table component

@1yne
Copy link
Contributor Author

1yne commented Sep 2, 2023

I'm quite new to creating components, so if there is any feedback, please do let me know

@BeeMargarida
Copy link
Member

Hey! I'll check this out this week. We are kinda in a freeze of new components, since we are in the process of migrating to a new solution for our style API (stitches was deprecated). I'll try to see if this can squeeze in, but it might be put on hold until the migration is complete

@BeeMargarida BeeMargarida added enhancement New feature or request component New or changes to components labels Sep 4, 2023
@1yne
Copy link
Contributor Author

1yne commented Sep 4, 2023

Sure! I just felt that if we could finish this, we could also start with #387

Copy link
Member

@BeeMargarida BeeMargarida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments. Thank you for taking the time to contribute this component 🙏

@1yne
Copy link
Contributor Author

1yne commented Sep 17, 2023

I've been trying to implement the changes but this error has been popping up ever since. Any ideas?

Screenshot 2023-09-17 at 11 03 55 PM

@BeeMargarida
Copy link
Member

BeeMargarida commented Sep 19, 2023

I've been trying to implement the changes but this error has been popping up ever since. Any ideas?

Hum, I'll check it out today. But even after clean install and everything?

@1yne
Copy link
Contributor Author

1yne commented Sep 19, 2023

Yup. I deleted my local files and cloned the fork again with a clean install. Still didn't work

@BeeMargarida
Copy link
Member

Yup. I deleted my local files and cloned the fork again with a clean install. Still didn't work

Hum, what version of node are you using?

@1yne
Copy link
Contributor Author

1yne commented Sep 22, 2023

Hum, what version of node are you using?

v16.18.0

@BeeMargarida
Copy link
Member

Hum, what version of node are you using?

v16.18.0

I can't replicate the issue 🤔 I'm using the same node version, removed node_modules, cleaned yarn cache and reinstalled, it's working ok. I normally use node 18 or 20, but even node 16 is working fine.

@1yne
Copy link
Contributor Author

1yne commented Oct 4, 2023

Hi, any update on this? I'm still not sure on what to do

@BeeMargarida
Copy link
Member

BeeMargarida commented Oct 4, 2023

Hey, I'm currently focusing on the style API migration. I'll check this out as soon as I can. I can try to make the stories, so that I can check that everything is working properly. However, I'm still not sure what's happening in your setup, I can't replicate it on my side.

@1yne
Copy link
Contributor Author

1yne commented Oct 4, 2023

Hey, I'm currently focusing on the style API migration. I'll check this out as soon as I can. I can try to make the stories, so that I can check that everything is working properly. However, I'm still not sure what's happening in your setup, I can replicate it on my side.

Sure, thanks for looking into it!

@BeeMargarida
Copy link
Member

BeeMargarida commented Nov 3, 2023

My bad, I pushed to the wrong branch. I'll revert it.

I'll try to take a look at this next week, perhaps it can be merged.

@wuleninja
Copy link

Thanks for this one! Until it's ready, I'll probably go with SMUI for a POC. But I'd rather use SvelteUI once it's completed with data tables 👍

@BeeMargarida
Copy link
Member

TODOs (note for me): add demos and docs

@1yne 1yne closed this by deleting the head repository Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component New or changes to components enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants