-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@svelteui/core]: Added Table component #456
Conversation
I'm quite new to creating components, so if there is any feedback, please do let me know |
Hey! I'll check this out this week. We are kinda in a freeze of new components, since we are in the process of migrating to a new solution for our style API (stitches was deprecated). I'll try to see if this can squeeze in, but it might be put on hold until the migration is complete |
Sure! I just felt that if we could finish this, we could also start with #387 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments. Thank you for taking the time to contribute this component 🙏
packages/svelteui-core/src/components/Table/Table.stories.svelte
Outdated
Show resolved
Hide resolved
Hum, I'll check it out today. But even after clean install and everything? |
Yup. I deleted my local files and cloned the fork again with a clean install. Still didn't work |
Hum, what version of node are you using? |
v16.18.0 |
I can't replicate the issue 🤔 I'm using the same node version, removed node_modules, cleaned yarn cache and reinstalled, it's working ok. I normally use node 18 or 20, but even node 16 is working fine. |
Hi, any update on this? I'm still not sure on what to do |
Hey, I'm currently focusing on the style API migration. I'll check this out as soon as I can. I can try to make the stories, so that I can check that everything is working properly. However, I'm still not sure what's happening in your setup, I can't replicate it on my side. |
Sure, thanks for looking into it! |
ISSUES CLOSED: #473
My bad, I pushed to the wrong branch. I'll revert it. I'll try to take a look at this next week, perhaps it can be merged. |
This reverts commit bb88110.
Thanks for this one! Until it's ready, I'll probably go with SMUI for a POC. But I'd rather use SvelteUI once it's completed with data tables 👍 |
TODOs (note for me): add demos and docs |
Description
Before submitting the PR, please make sure you do the following
[@svelteui/core]
,[@svelteui/actions]
,[@svelteui/motion]
,[@svelteui/core]
,[core]
, or[docs]
.yarn lint
andyarn test
or just runyarn prepush
.Adds a Table component