Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange and add missing keys for cy locales #1119

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

hmzasif
Copy link
Contributor

@hmzasif hmzasif commented Feb 13, 2024

This PR fixes the error messages by moving them under the errors: section to fix the test cases. It also adds missing keys.

@hmzasif hmzasif changed the title Arrange and add missing keys Arrange and add missing keys for cy locales Feb 13, 2024
one: Atalwyd y %{model} hwn rhag ei gadw gan 1 nam
two: Atalwyd y %{model} hwn rhag ei gadw gan %{count} nam
few: Atalwyd y %{model} hwn rhag ei gadw gan ychydig nam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t this still have the count variable?

Suggested change
few: Atalwyd y %{model} hwn rhag ei gadw gan ychydig nam
few: Atalwyd y %{model} hwn rhag ei gadw gan %{count} nam

@hmzasif hmzasif requested a review from sunny February 13, 2024 19:41
Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add an entry to the CHANGELOG as well?

@hmzasif
Copy link
Contributor Author

hmzasif commented Feb 13, 2024

Thanks! Could you add an entry to the CHANGELOG as well?

You are welcome, I have added it.

CHANGELOG.md Outdated
@@ -17,6 +17,7 @@
- Portuguese (pt-BR): am/pm
- Romanian (ro): am/pm
- Swedish (sv sv-FI sv-SE): am/pm
- Welsh (cy): Move the keys to rught place and add missing keys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is small typo here "rught" should "right"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for it; it's already been fixed.

@pama pama merged commit 3fbb72c into svenfuchs:master Feb 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants