Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend nib API to allow reuse of underlying writer #22

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Extend nib API to allow reuse of underlying writer #22

merged 1 commit into from
Oct 31, 2020

Conversation

svengreb
Copy link
Owner

Resolves #21

@svengreb svengreb added this to the 0.2.0 milestone Oct 31, 2020
@svengreb svengreb self-assigned this Oct 31, 2020
@svengreb
Extend nib API to allow reuse of underlying writer
329e934 
To allow to reuse the underlying io.Writer [1] a new
`Writer() io.Writer` method has been added to the `nib.Nib` interface
[2].
Both implementations the `pencil package [3] and `inkpen` package [4]
adapted this change.

[1]: https://pkg.go.dev/github.com/svengreb/nib#Nib
[2]: https://golang.org/pkg/io/#Writer
[3]: https://pkg.go.dev/github.com/svengreb/nib/pencil
[4]: https://pkg.go.dev/github.com/svengreb/nib/inkpen

GH-21
@svengreb svengreb force-pushed the feature/gh-21-nib-api-reuse-underlying-writer branch from cf5c5cb to 329e934 Compare October 31, 2020 12:57
@svengreb svengreb merged commit 2dac339 into main Oct 31, 2020
@svengreb svengreb deleted the feature/gh-21-nib-api-reuse-underlying-writer branch October 31, 2020 13:01
@svengreb svengreb removed their assignment Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
context-api context-pkg scope-compatiblity scope-ux type-feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Extend nib API to allow reuse of underlying writer
1 participant
@svengreb