Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golangci-lint v1.32.0 #21

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Update to golangci-lint v1.32.0 #21

merged 1 commit into from
Oct 30, 2020

Conversation

svengreb
Copy link
Owner

Resolves #20

@svengreb svengreb added this to the Next milestone Oct 30, 2020
@svengreb svengreb self-assigned this Oct 30, 2020
@svengreb
Update to golangci-lint v1.32.0
4ba3beb 
The currently latest `golangci-lint` version 1.32.0 [1] introduced new
linters that have been added to this template:

1. wrapcheck [2] — Checks that errors returned from external packages
   are wrapped.
   This linter is disabled by default, but has been enabled for this
   template to help tp reduce error context loss.
2. [errorlint][3] — Helps to make more efficient use of the error
   wrapping scheme introduced in Go 1.13.
   This linter is disabled by default, but has been enabled for this
   template to help to use Go's new error handling concept.
3. [tparallel][4] — Detects inappropriate usage of `t.Parallel()` method
   in Go tests.
   This linter is disabled by default, but has been enabled for this
   template to help to prevent parallelism errors in tests.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[2]: https://github.com/tomarrell/wrapcheck
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/moricho/tparallel

GH-20
@svengreb svengreb force-pushed the feature/gh-20-ugolangci-lint-version-1.32.0 branch from db5c880 to 4ba3beb Compare October 30, 2020 20:51
@svengreb svengreb merged commit 072aad9 into main Oct 30, 2020
@svengreb svengreb deleted the feature/gh-20-ugolangci-lint-version-1.32.0 branch October 30, 2020 20:58
@svengreb svengreb removed their assignment Oct 30, 2020
@svengreb svengreb mentioned this pull request Nov 10, 2020
Closed
svengreb added a commit to svengreb/nib that referenced this pull request Nov 11, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0
a32fd58 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

GH-25
svengreb added a commit to svengreb/nib that referenced this pull request Nov 11, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0 (#26)
eaef697 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

Closes GH-25
svengreb added a commit to svengreb/nib that referenced this pull request Nov 11, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0 (#26)
15285fb 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

Closes GH-25
@svengreb svengreb mentioned this pull request Nov 12, 2020
Closed
svengreb added a commit to svengreb/wand that referenced this pull request Nov 12, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0
b37945f 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

GH-4
svengreb added a commit to svengreb/wand that referenced this pull request Nov 12, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0 (#5)
f778fd9 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

Closes GH-4
svengreb added a commit to svengreb/wand that referenced this pull request Nov 12, 2020
@svengreb
Update to "tmpl-go" template repository version 0.5.0 (#5)
4176fc7 
Updated to `tmpl-go` version 0.5.0 [1] (including version 0.4.0 [2])
that...

1. ...introduces the initial project documentation [3].
2. ...updates golangci-lint to the currently latest version 1.32.0 [4]
   which introduces new linters like errorlint [5], tparallel [6] and
   wrapcheck [7].
3. ...updates to "tmpl" version 0.7.0 (GH-25 [8] GH-34 [9]).
   This includes...
   - ...a new configuration file for automated dependency updates and
     security alerts [10] with Dependabot [11]. Next to update
     configurations for the CI/CD GitHub action workflow [12] and
     Yarn/NPM dependencies [13], the file has been extended to support
     Go modules [14].
   - ...updates to the latest Node.js package dependency & GitHub Action
     versions.
   - ...a change of the NPM package name to use a namespace [15] which
     helps to prevent collisions with already existing NPM packages like
     tmpl [16].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.5.0
[2]: https://github.com/svengreb/tmpl-go/releases/tag/v0.4.0
[3]: svengreb/tmpl-go#32
[4]: svengreb/tmpl-go#21
[5]: https://github.com/polyfloyd/go-errorlint
[6]: https://github.com/moricho/tparallel
[7]: https://github.com/tomarrell/wrapcheck
[8]: svengreb/tmpl-go#25
[9]: svengreb/tmpl-go#34
[10]: svengreb/tmpl#52
[11]: https://dependabot.com
[12]: https://github.com/svengreb/tmpl#cicd-action-workflow
[13]: https://github.com/svengreb/tmpl#nodejs-yarn-and-npm
[14]: https://golang.org/ref/mod
[15]: svengreb/tmpl#48
[16]: https://www.npmjs.com/package/tmpl

Closes GH-4
@svengreb svengreb mentioned this pull request Nov 16, 2020
Closed
svengreb added a commit that referenced this pull request Nov 16, 2020
@svengreb
Disable "errorlint" to prevent false-positive errors
a7e9cd8 
In GH-21 [1] "golangci-lint" was updated to the currently latest version
1.32.0 [2] which introduced the errorlint [3] that has been enabled for
this template repository. As it turns out it causes a lot of
false-positives errors for code lines that explicitly do not wrap the
error to prevent it become part of the public API.
Therefore the linter has been disabled again because the update also
introduced the new wrapcheck [4] linter which helps to prevent that
errors from external packages are exposed to the public API.

[1]: #21
[2]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/tomarrell/wrapcheck

GH-39
svengreb added a commit that referenced this pull request Nov 16, 2020
@svengreb
Disable "errorlint" to prevent false-positive errors (#40)
28f888a 
In GH-21 [1] "golangci-lint" was updated to the currently latest version
1.32.0 [2] which introduced the errorlint [3] that has been enabled for
this template repository. As it turns out it causes a lot of
false-positives errors for code lines that explicitly do not wrap the
error to prevent it become part of the public API.
Therefore the linter has been disabled again because the update also
introduced the new wrapcheck [4] linter which helps to prevent that
errors from external packages are exposed to the public API.

[1]: #21
[2]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/tomarrell/wrapcheck

Closes GH-39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
context-techstack scope-compatibility scope-quality type-feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Update to golangci-lint version 1.32.0
1 participant
@svengreb