build(npm): bumps glob to latest BREAKING (#770)

sverweij · Apr 1, 2023 · 334a3ce · 334a3ce
1 parent bbc7bbf
commit 334a3ce
Show file tree

Hide file tree

Showing 14 changed files with 17 additions and 19 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -81,7 +81,6 @@ jobs:
           SHA=${{github.event.pull_request.base.sha}} yarn --silent depcruise:graph:mermaid:diff >> $GITHUB_STEP_SUMMARY
           echo '' >> $GITHUB_STEP_SUMMARY
           echo '```' >> $GITHUB_STEP_SUMMARY
-
       - name: regular test (run on node != ${{env.NODE_LATEST}} only)
         if: matrix.node-version != env.NODE_LATEST
         run: npm test

diff --git a/package.json b/package.json
@@ -143,7 +143,7 @@
     "enhanced-resolve": "5.12.0",
     "figures": "^3.2.0",
     "get-stream": "^6.0.1",
-    "glob": "7.2.0",
+    "glob": "9.3.2",
     "handlebars": "4.7.7",
     "ignore": "5.2.4",
     "indent-string": "^4.0.0",
@@ -214,11 +214,6 @@
         "policy": "wanted",
         "because": "version 4 only exports esm - and we use cjs and don't transpile"
       },
-      {
-        "package": "glob",
-        "policy": "pin",
-        "because": "from version 7.2.1 behavior on windows changes - in a potentially breaking fashion. Wait with upgrading until we're majoring or from when there's a vuln in 7.2.0"
-      },
       {
         "package": "indent-string",
         "policy": "wanted",

diff --git a/src/extract/gather-initial-sources.js b/src/extract/gather-initial-sources.js
@@ -101,7 +101,11 @@ module.exports = function gatherInitialSources(
   return pFileAndDirectoryArray
     .reduce(
       (pAll, pFileOrDirectory) =>
-        pAll.concat(glob.sync(pFileOrDirectory, { cwd: lOptions.baseDir })),
+        pAll.concat(
+          glob.sync(pathToPosix(pFileOrDirectory), {
+            cwd: pathToPosix(lOptions.baseDir),
+          })
+        ),
       []
     )
     .reduce((pAll, pFileOrDirectory) => {

diff --git a/src/meta.js b/src/meta.js
@@ -3,7 +3,7 @@
 module.exports = {
   version: "12.11.0",
   engines: {
-    node: "^14||^16||>=18",
+    node: "^16.14||>=18",
   },
   supportedTranspilers: {
     babel: ">=7.0.0 <8.0.0",

diff --git a/test/cli/validate-node-environment.spec.mjs b/test/cli/validate-node-environment.spec.mjs
@@ -40,7 +40,7 @@ describe("[U] cli/validateNodeEnv", () => {
 
   it("doesn't throw when a supported node version is passed", () => {
     expect(() => {
-      validateNodeEnvironment("16.0.0");
+      validateNodeEnvironment("18.0.0");
     }).to.not.throw();
   });
 });
diff --git a/test/extract/__fixtures__/cache-busting-first-tree.json b/test/extract/__fixtures__/cache-busting-first-tree.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/cache-busting/index.ts",
+    "source": "test/extract/__mocks__/cache-busting/index.ts",
     "dependencies": [
       {
         "resolved": "test/extract/__mocks__/cache-busting/local.js",

diff --git a/test/extract/__fixtures__/cache-busting-second-tree.json b/test/extract/__fixtures__/cache-busting-second-tree.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/cache-busting/index.ts",
+    "source": "test/extract/__mocks__/cache-busting/index.ts",
     "dependencies": [
       {
         "resolved": "test/extract/__mocks__/cache-busting/local.js",

diff --git a/test/extract/__fixtures__/donotfollow-dependency-types.json b/test/extract/__fixtures__/donotfollow-dependency-types.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/donotfollow-dependency-types/index.js",
+    "source": "test/extract/__mocks__/donotfollow-dependency-types/index.js",
 
     "dependencies": [
       {

diff --git a/test/extract/__fixtures__/donotfollow.json b/test/extract/__fixtures__/donotfollow.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/donotfollow/index.js",
+    "source": "test/extract/__mocks__/donotfollow/index.js",
 
     "dependencies": [
       {

diff --git a/test/extract/__fixtures__/maxDepth0.json → test/extract/__fixtures__/max-depth-0.json b/test/extract/__fixtures__/maxDepth0.json → test/extract/__fixtures__/max-depth-0.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/maxDepth/index.js",
+    "source": "test/extract/__mocks__/maxDepth/index.js",
     "dependencies": [
       {
         "resolved": "test/extract/__mocks__/maxDepth/oneAndTwoDeep.js",

diff --git a/test/extract/__fixtures__/maxDepth1.json → test/extract/__fixtures__/max-depth-1.json b/test/extract/__fixtures__/maxDepth1.json → test/extract/__fixtures__/max-depth-1.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/maxDepth/index.js",
+    "source": "test/extract/__mocks__/maxDepth/index.js",
     "dependencies": [
       {
         "resolved": "test/extract/__mocks__/maxDepth/oneAndTwoDeep.js",

diff --git a/test/extract/__fixtures__/maxDepth2.json → test/extract/__fixtures__/max-depth-2.json b/test/extract/__fixtures__/maxDepth2.json → test/extract/__fixtures__/max-depth-2.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/maxDepth/index.js",
+    "source": "test/extract/__mocks__/maxDepth/index.js",
 
     "dependencies": [
       {

diff --git a/test/extract/__fixtures__/maxDepth4.json → test/extract/__fixtures__/max-depth-4.json b/test/extract/__fixtures__/maxDepth4.json → test/extract/__fixtures__/max-depth-4.json
@@ -1,6 +1,6 @@
 [
   {
-    "source": "./test/extract/__mocks__/maxDepth/index.js",
+    "source": "test/extract/__mocks__/maxDepth/index.js",
 
     "dependencies": [
       {

diff --git a/test/extract/index.maxdepth.spec.mjs b/test/extract/index.maxdepth.spec.mjs
@@ -30,7 +30,7 @@ describe("[I] extract/index - max depth", () => {
       /* eslint import/no-dynamic-require:0, security/detect-non-literal-require:0 */
 
       expect(lResult).to.deep.equal(
-        requireJSON(`./__fixtures__/maxDepth${pDepth}.json`)
+        requireJSON(`./__fixtures__/max-depth-${pDepth}.json`)
       );
       // expect(lResult).to.be.jsonSchema(resultSchema);
     })