Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): converts to esm #765

Merged
merged 1 commit into from
Apr 2, 2023
Merged

chore(cli): converts to esm #765

merged 1 commit into from
Apr 2, 2023

Conversation

sverweij
Copy link
Owner

Description

  • converts all cli-only javascript to esm

Motivation and Context

  • first step to convert everything to esm; which will make working the javascript ecosystem over time easier.

How Has This Been Tested?

  • green ci
  • local runs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it

  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the chore/convert-wrap-stream-in-html-to-esm branch 2 times, most recently from b728ea0 to 79d5a26 Compare April 1, 2023 18:43
@sverweij sverweij changed the base branch from develop to v13 April 1, 2023 19:31
@sverweij sverweij force-pushed the chore/convert-wrap-stream-in-html-to-esm branch 6 times, most recently from d08e36e to fa2d995 Compare April 1, 2023 22:16
@sverweij sverweij force-pushed the chore/convert-wrap-stream-in-html-to-esm branch from fa2d995 to 8fd6c47 Compare April 2, 2023 07:51
@sverweij sverweij merged commit 911c6fa into v13 Apr 2, 2023
@sverweij sverweij deleted the chore/convert-wrap-stream-in-html-to-esm branch April 2, 2023 08:12
sverweij added a commit that referenced this pull request Apr 2, 2023
@sverweij
chore(cli): converts to esm (#765)
cf4fab1
sverweij added a commit that referenced this pull request Apr 2, 2023
@sverweij
chore(cli): converts to esm (#765)
822afeb
@sverweij sverweij mentioned this pull request Apr 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sverweij