Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config-utl): converts to esm #772

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Apr 2, 2023

Description

  • converts the config-utl modules to esm

TODO:

  • convert the webpack config-utl
  • decide whether we want to keep the cjs interface (and if so, how) - if so - separate PR
  • document that all of a sudden it's possible to use es-modules for babel and dependency-cruiser configs.
  • find out what exception we have to build in for the MS windows platform this time

Motivation and Context

See other ESM conversion PR's

How Has This Been Tested?

  • green ci
  • manual run-through

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/rewrite-config-utl-to-esm branch 6 times, most recently from 94a752d to 63dd3d3 Compare April 6, 2023 08:08
@sverweij sverweij force-pushed the refactor/rewrite-config-utl-to-esm branch from 63dd3d3 to 6f9be06 Compare April 6, 2023 08:12
@sverweij sverweij changed the title WIP: chore(config-utl): converts to esm chore(config-utl): converts to esm Apr 6, 2023
@sverweij sverweij merged commit 701e020 into v13 Apr 6, 2023
@sverweij sverweij deleted the refactor/rewrite-config-utl-to-esm branch April 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant