Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(extract): converts to esm BREAKING #774

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Apr 6, 2023

Description

  • converts the main/index.js module to esm
  • converts the extract functionality to esm
  • makes the cruise interface async - BREAKING

For this it was necessary to make the main cruise interface asynchronous - specifically in this PR as normalizing the resolve options requires a dynamic import.

Motivation and Context

See earlier PR's on converting to esm.

How Has This Been Tested?

  • green ci
  • updated automated tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij changed the title refactor(extract): converts extract to esm BREAKING WIP: refactor(extract): converts extract to esm BREAKING Apr 6, 2023
@sverweij sverweij force-pushed the refactor/converts-main-to-esm branch 8 times, most recently from 9aee0f0 to 54753c9 Compare April 8, 2023 07:56
@sverweij sverweij changed the title WIP: refactor(extract): converts extract to esm BREAKING refactor(extract): converts extract to esm BREAKING Apr 8, 2023
@sverweij sverweij changed the title refactor(extract): converts extract to esm BREAKING refactor(extract): converts to esm BREAKING Apr 8, 2023
@sverweij sverweij force-pushed the refactor/converts-main-to-esm branch from 54753c9 to a23ba91 Compare April 8, 2023 08:20
@sverweij sverweij merged commit dc211d0 into v13 Apr 8, 2023
@sverweij sverweij deleted the refactor/converts-main-to-esm branch April 8, 2023 08:22
sverweij added a commit that referenced this pull request Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant