Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(config-utl): enables webpack configurations in ESM format BREAKING #792

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

sverweij
Copy link
Owner

Description

  • uses import instead of require for webpack configurations that look like they can be loaded natively.
  • still uses the require hack with rechoir/ interpret for configurations that look different.

This makes the config util that loads webpack configurations asynchronous which is 🚨 BREAKING.

Motivation and Context

  • to remain consistent with the formats we support for babel and dependency-cruiser itself.
  • because it's possible now.

How Has This Been Tested?

  • green ci
  • updated automated integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 290923b into v13 Apr 14, 2023
@sverweij sverweij deleted the feature/enables-mjs-webpack-configurations branch April 22, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant