Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema|types): adds 'checksum' attribute & null reporter to the module schema & types #803

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

sverweij
Copy link
Owner

Description

  • adds the optional 'checksum' attribute to the module json schema
  • adds the 'null' reporter to the list of allowed reporters in the json schema
  • adds the optional 'checksum' attribute to the module type definition
  • adds the 'null' reporter to the list of allowed reporters in the type definitions

Motivation and Context

When you use the 'json' reporter and the result comes from a content based cache, the module will contain the 'checksum' attribute. As this attribute isn't available in the schema or the type definition that json would show up as invalid when validated against a json validator (or type checker, for that matter). Same with the 'null' reporter.

Concrete case: running depcruise-fmt either directly against a content based cache or result thereof would throw an error.

How Has This Been Tested?

  • green ci
  • manual check with depcruise-fmt against a content based cache

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 5d62d58 into develop Apr 30, 2023
@sverweij sverweij deleted the bugfix/adds-checksum-attribute-to-schema branch April 30, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant