-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolve)!: makes alias type derivation more correct and precise BREAKING #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverweij
force-pushed
the
bugfix/also-merge-workspaces
branch
3 times, most recently
from
November 24, 2023 09:30
eaec411
to
89e8e8b
Compare
9 tasks
sverweij
force-pushed
the
bugfix/also-merge-workspaces
branch
4 times, most recently
from
December 1, 2023 12:28
b54b02d
to
5a6dd8a
Compare
sverweij
changed the title
fix(resolve): takes 'workspaces' field into account when merging package manifests
this is an INCORRECT PR TITLE takes 'workspaces' field into account when merging package manifests
Dec 1, 2023
sverweij
changed the title
this is an INCORRECT PR TITLE takes 'workspaces' field into account when merging package manifests
fix(resolve): takes 'workspaces' field into account when merging package manifests
Dec 1, 2023
sverweij
force-pushed
the
bugfix/also-merge-workspaces
branch
from
December 1, 2023 18:53
5a6dd8a
to
c9b8d30
Compare
sverweij
changed the title
fix(resolve): takes 'workspaces' field into account when merging package manifests
fix(resolve): makes alias type derivation more correct
Dec 3, 2023
sverweij
changed the title
fix(resolve): makes alias type derivation more correct
fix(resolve): makes alias type derivation more correct and precise
Dec 3, 2023
sverweij
force-pushed
the
bugfix/also-merge-workspaces
branch
2 times, most recently
from
December 6, 2023 13:35
6452d6d
to
54c39f6
Compare
…ence to node native aliases might there be a conflict
This reverts commit 1b17592.
…ency types to json schema & types
…config-base-url' dependency types
sverweij
force-pushed
the
bugfix/also-merge-workspaces
branch
from
December 9, 2023 10:35
54c39f6
to
a995d26
Compare
Code Climate has analyzed commit a995d26 and detected 0 issues on this pull request. View more on Code Climate. |
sverweij
changed the title
fix(resolve): makes alias type derivation more correct and precise
fix(resolve)~: makes alias type derivation more correct and precise BREAKING
Dec 9, 2023
sverweij
changed the title
fix(resolve)~: makes alias type derivation more correct and precise BREAKING
fix(resolve)!: makes alias type derivation more correct and precise BREAKING
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
alias-tsconfig-base-url
andalias-tsconfig-paths
dependency types to distinguish between the two types of aliases one can use within tsconfigs. B.t.w. for both dependency-cruiser will keep emitting thealias
andalias-tsconfig
dependency types as well - both for convenience and backwards compatibility.This PR is theoretically 🚨 BREAKING as rules previously defined on aliases, that didn't fire now will because they're now detected correctly.
Motivation and Context
Now we're doing explicit things with
workspaces
andimports
fields we need to have them in merged package manifests as well, so in monorepos we still take them into account. The rewrite of the tsconfig alias detection logic is necessary to ensure we detect tsconfig aliases correctly and more precisely.Also see #863.
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️