Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces chalk with picocolors #945

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 6, 2024

Description

  • replaces chalk with picocolors
  • test: removes chalk setup & tear down code in before & after triggers in lieu of setting the NO_COLOR environment variable

Motivation and Context

  • picocolors is ~ 1/3 of the size of even chalk5 (chalk: 5.4kb/2.3kb zipped/ 44kb install vs picocolors: 1.7kb/0.7kb zipped/ 5.2kb install) which better for both loading times & download times/ footprint.
  • picocolors suports NO_COLOR which is helpful for dependency-cruiser's A11Y
  • (from the department of due diligence: picocolors has a sizeable download count, several major packages use it, it has recent updates (2 months ago vs 1y ago on chalk))

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Jul 6, 2024

Code Climate has analyzed commit d7c481a and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 78810ce into main Jul 6, 2024
13 checks passed
@sverweij sverweij deleted the refactor/replaces-chalk-with-tiny-colors branch July 6, 2024 15:12
@sverweij sverweij changed the title refactor: replaces chalk with tinycolors refactor: replaces chalk with picocolors Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant