-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds 'ancestor' matcher #961
Draft
sverweij
wants to merge
5
commits into
main
Choose a base branch
from
feature/adds-ancestor-matcher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverweij
force-pushed
the
feature/adds-ancestor-matcher
branch
from
November 3, 2024 18:07
dd5fedb
to
43e5d79
Compare
sverweij
force-pushed
the
feature/adds-ancestor-matcher
branch
from
November 14, 2024 20:51
43e5d79
to
819d9f6
Compare
13 tasks
sverweij
force-pushed
the
feature/adds-ancestor-matcher
branch
from
November 17, 2024 20:06
819d9f6
to
9b9ea4d
Compare
sverweij
force-pushed
the
main
branch
7 times, most recently
from
November 22, 2024 19:26
95331ab
to
aae6edd
Compare
sverweij
force-pushed
the
feature/adds-ancestor-matcher
branch
from
November 24, 2024 13:54
9b9ea4d
to
befba72
Compare
Code Climate has analyzed commit befba72 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ancestor
matcherMotivation and Context
It's probably possible to do this with regular expressions and group matching, but so far I haven't found a simple way to do that.
How Has This Been Tested?
Screenshots
You can now do things like this:
Which, when run as part of a validation, would yield errors on every dependency that goes folders up in stead of down:
Types of changes
Checklist
📖
⚖️