Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extract): adds recognition of jsdoc 'bracket' imports #969

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 24, 2024

Description

  • adds recognition for the 'older' bracket style imports in jsdoc
    (so things like /** @type {import('thing')} */, /** @typedef {import('thing')} Thing */, /** @param {import('thing')} pParameter blablabla */, ...)

TODO

Motivation and Context

How Has This Been Tested?

  • green ci
  • additional unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 24, 2024

Code Climate has analyzed commit f05d8e8 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 24, 2024

@sverweij sverweij marked this pull request as draft November 24, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant