Refactor removeUnusedNS plugin #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TrySound
commented
Sep 5, 2021
TrySound
commented
- covered with types
- migrated to visitor plugin api
- dropped traverse utility which is replaced by visitor
- covered with types - migrated to visitor plugin api - dropped traverse utility which is replaced by visitor
matheus1lva
approved these changes
Sep 5, 2021
omgovich
approved these changes
Sep 10, 2021
plugins/removeUnusedNS.js
Outdated
Comment on lines
33
to
46
| // remove element namespace from collected list | ||
| if (node.name.includes(':')) { | ||
| const [ns] = node.name.split(':'); | ||
| if (definedNamespaces.has(ns)) { | ||
| definedNamespaces.delete(ns); | ||
| } | ||
| } | ||
| // check each attr for the ns-attrs | ||
| for (const name of Object.keys(node.attributes)) { | ||
| if (name.includes(':')) { | ||
| const [ns] = name.split(':'); | ||
| definedNamespaces.delete(ns); | ||
| } | ||
| } |
There was a problem hiding this comment.
The code looks good, but it feels like it doesn't have enough explanation to help other developers to understand it faster. For example, we remove some elements from definedNamespaces but there is a lack of explanation why we do that. Would be better to have reference to some specs or describe the goal. Examples:
// Collect all namespaces from the svg element
// (such as `xmlns:xlink="http://www.w3.org/1999/xlink"`)
if (node.name === 'svg' && parentNode.type === 'root') {
// We must preserve a namespace if there are nested elements that refer
// to the same namespace in their names
if (node.name.includes(':')) {
// ...
// Dropping a namespace from the root element might break the rendering of elements
// that use this namespace in attribute names
for (const name of Object.keys(node.attributes)) {
// ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.