Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failed on Windows #1850

Merged
merged 1 commit into from
Nov 26, 2023
Merged

test failed on Windows #1850

merged 1 commit into from
Nov 26, 2023

Conversation

johnkenny54
Copy link
Contributor

'should respect line-ending config' failed because parameters were out of order on expected result. CRLF version of the tests was out of sync with LF version.

Fixes #1849

'should respect line-ending config' failed because parameters were out
of order on expected result
@SethFalco
Copy link
Member

Thanks for reporting and fixing this for us!

This one was my fault, those tests get skipped both for me and on our CI environment. ^-^'
Later I'll evaluate if we can include a Windows runner in our pipeline to catch this in future.

@SethFalco SethFalco merged commit 8879fcb into svg:main Nov 26, 2023
6 checks passed
@johnkenny54 johnkenny54 deleted the svgo-node branch December 29, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svgo-node.test.js fails on Windows
2 participants