New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve Jest tests with more precise assertions #1912

Merged

SethFalco merged 1 commit into svg:main from jdufresne:jest-to-strict-equal

Dec 28, 2023

Contributor

jdufresne commented Dec 27, 2023

Avoid type coercion for assertions by using toBe, toBeNull, and toStrictEqual.

These matchers are documented at:

jdufresne changed the title ~~Improve Jest tests with more precise assertions~~ chore: Improve Jest tests with more precise assertions


          Improve Jest tests with more precise toBe and toStrictEqual

32cdc93

Avoid type coercion for assertions by using toBe, toBeNull, and
toStrictEqual.

These matchers are documented at:

- https://jestjs.io/docs/expect#tobevalue
- https://jestjs.io/docs/expect#tostrictequalvalue
- https://jestjs.io/docs/expect#tobenull

SethFalco force-pushed the jest-to-strict-equal branch from 13b6be5 to 32cdc93 Compare

December 28, 2023 19:11

SethFalco merged commit f6a2ca2 into svg:main

10 checks passed

jdufresne deleted the jest-to-strict-equal branch

December 28, 2023 20:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet