Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup goreleaser config #102

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fixup goreleaser config #102

merged 1 commit into from
Sep 29, 2023

Conversation

svix-onelson
Copy link
Contributor

Looks like our config was outdated, and workflow used deprecated flags. These seem to have prevented the v0.20.0 release from happening.

Refs:

@svix-onelson svix-onelson requested review from a team and removed request for a team September 29, 2023 17:54
@svix-onelson svix-onelson marked this pull request as draft September 29, 2023 18:00
@svix-onelson
Copy link
Contributor Author

svix-onelson commented Sep 29, 2023

I fixed up the first round things visible from the attempted release in August, but having just run the check locally, I see some other stuff that's out of whack.

goreleaser check
  • checking                                 path=
  • DEPRECATED:  brews.tap  should not be used anymore, check https://goreleaser.com/deprecations#brewstap for more info
  • DEPRECATED:  scoop  should not be used anymore, check https://goreleaser.com/deprecations#scoop for more info
  • DEPRECATED:  scoops.bucket  should not be used anymore, check https://goreleaser.com/deprecations#scoopsbucket for more info
  • .goreleaser.yml                                  error=configuration is valid, but uses deprecated properties
  ⨯ command failed                                   error=1 out of 1 configuration file(s) have issues

Will try to work through it.


goreleaser check
  • checking                                 path=
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

I get a pass from goreleaser check locally using 1.21.2 (the most recent non-nightly). Looks like all these deprecations kicked in back in July.

Looks like our config was outdated, and workflow used deprecated flags.
These seem to have prevented the v0.20.0 release from happening.

Refs:
- <https://github.com/svix/svix-cli/actions/runs/5756141108/job/15605015680#step:5:19>
- <goreleaser/goreleaser#3625>
@svix-onelson svix-onelson marked this pull request as ready for review September 29, 2023 18:07
@svix-onelson svix-onelson requested a review from a team September 29, 2023 18:07
@tasn tasn merged commit 663e0bb into main Sep 29, 2023
1 check passed
@tasn tasn deleted the onelson/fixup-goreleaser-cfg branch September 29, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants