Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade svix libs and fix default endpoint version in 'create endpoint' command #98

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

svix-lucho
Copy link
Contributor

  • Upgrade svix-webhooks to 1.7.0. Add context parameter in all calls since it's now required by the svix client.

  • Fix default endpoint version. The default value for endpoint version flag was 0, causing the cli to make an invalid request (422) when trying to create an endpoint without the version flag (svix create endpoint --data-url https://example.com).

Screenshot 2023-07-31 at 5 25 09 PM

@svix-lucho svix-lucho self-assigned this Jul 31, 2023
svix-onelson
svix-onelson previously approved these changes Aug 2, 2023
Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. We probably don't need to make a decision about the ctx right now, but wanted to raise the issue.

cmd/application.go Outdated Show resolved Hide resolved
Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/root.go Show resolved Hide resolved
@svix-lucho svix-lucho merged commit a91eae1 into main Aug 3, 2023
1 check passed
@svix-lucho svix-lucho deleted the lucho/bump-libs-fix-version branch August 3, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants