Add redis sentinel support #1472
Open
+445
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
redis-sentinel
branch
6 times, most recently
from
35c1082
to
b9e611d
Compare
jaymell
commented
Oct 3, 2024
| @@ -68,7 +68,7 @@ urlencoding = "2.1.2" | |||
| form_urlencoded = "1.1.0" | |||
| lapin = "2.1.1" | |||
| sentry = { version = "0.32.2", features = ["tracing"] } | |||
| omniqueue = { git = "https://github.com/svix/omniqueue-rs", rev = "5ae22000e2ea214ba707cac81657f098e5785a76", default-features = false, features = ["in_memory", "rabbitmq-with-message-ids", "redis_cluster"] } | |||
| omniqueue = { git = "https://github.com/jaymell/omniqueue-rs", rev = "55f3bccb4298c5de75da1358675f6bfadb016222", default-features = false, features = ["in_memory", "rabbitmq-with-message-ids", "redis_cluster", "redis_sentinel"] } | |||
There was a problem hiding this comment.
This will be updated once upstream PR is merged.
This adds support for using Redis Sentinel for queuing and caching. Sentinel potentially requires a lot of additional configuration params, so support for that that has been added here, although the `redis_dsn` field has been reused and should point to a sentinel server if using the `redissentinel` queue/cache types.
This test is flaky around the fifth run for some reason. My guess is because another cleanup process is interfering, which seems strange but not impossible. Anyway, moving the content-existence check to _before_ changing its expiration seems to fix the issue.
jaymell
force-pushed
the
redis-sentinel
branch
from
b9e611d
to
35ab20e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using Redis Sentinel for queuing and caching.
Sentinel potentially requires a lot of additional configuration params,
so support for that that has been added here, although the
redis_dsnfield has been reused and should point to a sentinel server if using the
redissentinelqueue/cache types.