Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js: Support setting a request timeout #1687

Merged
merged 1 commit into from
Feb 4, 2025
Merged

js: Support setting a request timeout #1687

merged 1 commit into from
Feb 4, 2025

Conversation

svix-jplatte
Copy link
Member

Closes #1652.

@svix-jplatte svix-jplatte requested a review from a team as a code owner February 3, 2025 15:24
svix-onelson
svix-onelson approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@svix-onelson svix-onelson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: what's the behavior when timeout is <= 0?

@svix-jplatte
Copy link
Member Author

Nasal demons.

(I'll check tomorrow)

@svix-jplatte
Copy link
Member Author

Similar errors on Firefox and Chrome:

Uncaught TypeError: Failed to execute 'timeout' on 'AbortSignal': Value is outside the 'unsigned long long' value range.

MDN just says it must be between 0 and Number.MAX_SAFE_INTEGER, not what happens if it isn't.

@svix-jplatte svix-jplatte merged commit c0fdb39 into main Feb 4, 2025
8 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/js-request-timeout branch February 4, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-onelson svix-onelson svix-onelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to configure request timeout on javascript client
2 participants
@svix-jplatte @svix-onelson