Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Subscription to (simple) Mute provides the false if muted. #194

Closed
hklages opened this issue Apr 29, 2024 · 3 comments
Closed

BUG: Subscription to (simple) Mute provides the false if muted. #194

hklages opened this issue Apr 29, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@hklages
Copy link
Contributor

hklages commented Apr 29, 2024

What happened

After having moved from 2.5.0 to 2.6.0-beta-10 the mute subscription provides wrong data:
(by the way beta-10 does not show up on the top instead beta-9 is on top of releases in Github)

  • RenderingControl service event does not provide the correct mute state instead it is always false.

What did you expect to happen

Should be true if player changes from unmute to mute.

How to reproduce it (minimal and precise)

  1. Subcribe to RenderingControl service for a specific player (.Events.on)
  2. change mute state to mute
    output is always "false"

GroupRenderingControl works fine.

Debug logging

let me know what you need. Debugging is not so easy in Node-RED containers.

Environment

  • sonos-ts version: 2.6.0-beta-10
  • OS: unraid container, Windows11
  • node version (node -v): any
@svrooij
Copy link
Owner

svrooij commented May 1, 2024

A fix will be there shortly. It was a small change that I overlooked with the xml parser

https://github.com/svrooij/node-sonos-ts/pull/195/files#diff-3ca06a54a05a61bac9a63c4703642d7c5e8669e3b58096bf0e277a347bb8fe7cR10

svrooij added a commit that referenced this issue May 1, 2024
* fix: Mute parsed from events #194
* feat: Created some RenderingControl extensions
@svrooij
Copy link
Owner

svrooij commented May 1, 2024

@hklages version 2.6.0-beta.11 should fix your issue npm, can you close this issue if your problem is solved?

@hklages
Copy link
Contributor Author

hklages commented May 1, 2024

Thanks! It works on my system and is also confirmed by another user.

@hklages hklages closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants