Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some packages and apply needed compliance to xmlParser Changes (src:@theimo1221) #185

Closed
wants to merge 1 commit into from

Conversation

simojenki
Copy link

Update to adress fast-xml security vulnerability

Description

This PR updates the package and contains needed changes to comply to new functionality of the library.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

💔 Thank you!

@svrooij
Copy link
Owner

svrooij commented Feb 6, 2024

It fails on some of the AlarmClockService tests.
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7661401338

  • -1 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 80.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/helpers/xml-helper.ts 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
src/sonos-device.ts 6 70.92%
Totals Coverage Status
Change from base Build 5474567724: -0.6%
Covered Lines: 1694
Relevant Lines: 2070

💛 - Coveralls

@svrooij
Copy link
Owner

svrooij commented Feb 7, 2024

No more fast-xml-parser..... v2.6.0-beta.6...v2.6.0-beta.7

@svrooij svrooij closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants