Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safearea around all the screens #281

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

DeD1rk
Copy link
Member

@DeD1rk DeD1rk commented Nov 2, 2022

Closes #169.

@DeD1rk
Copy link
Member Author

DeD1rk commented Nov 3, 2022

@JAicewizard sadly this doesn't quite do what you'd expect of it: (see bottom of screen) https://user-images.githubusercontent.com/41264528/199676602-47b29484-2d8e-47db-9b6e-744265ae001b.MOV

@JAicewizard JAicewizard force-pushed the add-safearea-everywhere branch from 36506bd to aa89844 Compare December 1, 2022 23:18
@JAicewizard
Copy link
Contributor

Ive never seen git make such a mess with just a single commit, I checked everything hope nothing wrong changed. Just a simple rebase

@DeD1rk
Copy link
Member Author

DeD1rk commented Dec 2, 2022

Github often takes a minute to correctly display the commit list after a rebase, looks fine now.

This fixes lists not scrolling under the safearea, and works around
issues with CustomScrollView
@JAicewizard
Copy link
Contributor

The solution for safearea+CustomScrollView is a giant hack, but it does work. Unlike Listview it doesnt automatically add padding around its children, so we have to manually add padding around the entire view for left/right and padding at the bottom/top inside the list itself. Maybe this could be hidden away in a custom widget that wraps CustomScrollView with propper padding? Would make things cleaner. To actually make sure the children don't also add a safearea we will have to make changes some changes again ant it will only make it uglier.

lib/ui/screens/albums_screen.dart Outdated Show resolved Hide resolved
lib/ui/screens/calendar_screen.dart Outdated Show resolved Hide resolved
lib/ui/screens/food_admin_screen.dart Show resolved Hide resolved
@JAicewizard JAicewizard self-requested a review December 24, 2022 23:54
Copy link
Member Author

@DeD1rk DeD1rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the code quality! There are some discrepancies on some screens, but those will be hard to find with a screen without notched bottom. I'll try to fix those myself soon

JAicewizard
JAicewizard previously approved these changes Jan 18, 2023
@JAicewizard
Copy link
Contributor

@DeD1rk review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bottom padding consistent over all screens.
2 participants