Refactor ListState and paginated screens #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now used only for the calendar, as that will be refactored a lot soon.
JAicewizard
requested changes
Feb 1, 2023
DeD1rk
force-pushed
the
refactor-eventscreen
branch
from
88b536d to
259946e
Compare
JAicewizard
requested changes
Feb 1, 2023
Comment on lines
+68
to
+71
| final state = cubit.state; | ||
| if (state is ResultsListState && | ||
| state is! DoneListState && | ||
| state is! LoadingMoreListState) { |
There was a problem hiding this comment.
This can be removed as more already checks this.
Comment on lines
+112
to
+125
| slivers = [ | ||
| ...resultSlivers, | ||
| if (state is LoadingMoreListState) | ||
| const SliverPadding( | ||
| padding: EdgeInsets.only(top: 16), | ||
| sliver: SliverToBoxAdapter( | ||
| child: Center(child: CircularProgressIndicator()), | ||
| ), | ||
| ), | ||
| const SliverSafeArea( | ||
| minimum: EdgeInsets.only(bottom: 8), | ||
| sliver: SliverPadding(padding: EdgeInsets.zero), | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
This only adds a safe area at the bottom, and if there needs to be a safearea at the top it will also add that in this widget.
Maybe just use the scrollview from #264 since that handles all the padding? or merge that first but this could result in weird UI in some phones, like maybe the samsung fold when rotated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #99.
Summary
This replaces the old ListState in a way similar to what I did in #325. Introduces
PaginatedScrollViewand aPaginatedCubitabstract class to handle most logic for paginated lists/grids.How to test
Steps to test the changes you made:
SafeArea.