feat(ns-json-schema-draft-4): complete replace empty elements plugin

Refs #1814
swagger-api · Aug 17, 2022 · 52ac8d4 · 52ac8d4
1 parent 4367a9e
commit 52ac8d4
Show file tree

Hide file tree

Showing 3 changed files with 82 additions and 1 deletion.
diff --git a/packages/apidom-ns-json-schema-draft-4/src/refractor/plugins/replace-empty-element.ts b/packages/apidom-ns-json-schema-draft-4/src/refractor/plugins/replace-empty-element.ts
@@ -121,6 +121,14 @@ const schema = {
       return new MediaElement(...args);
     },
   },
+  LinkDescriptionElement: {
+    targetSchema(...args: any[]) {
+      return new JSONSchemaElement(...args);
+    },
+    schema(...args: any[]) {
+      return new JSONSchemaElement(...args);
+    },
+  },
   'json-schema-properties': {
     '[key: *]': function key(...args: any[]) {
       return new JSONSchemaElement(...args);

diff --git a/...chema-draft-4/test/refractor/plugins/replace-empty-element/__snapshots__/mappings.ts.snap b/...chema-draft-4/test/refractor/plugins/replace-empty-element/__snapshots__/mappings.ts.snap
@@ -13,6 +13,34 @@ exports[`given JSON Schema definition with no empty values should do nothing 1`]
         (JSONSchemaDraft4Element)))))
 `;
 
+exports[`given empty value for LinkDescription.schema field should replace empty value with semantic element 1`] = `
+(JSONSchemaDraft4Element
+  (MemberElement
+    (StringElement)
+    (StringElement))
+  (MemberElement
+    (StringElement)
+    (ArrayElement
+      (LinkDescriptionElement
+        (MemberElement
+          (StringElement)
+          (JSONSchemaDraft4Element))))))
+`;
+
+exports[`given empty value for LinkDescription.targetSchema field should replace empty value with semantic element 1`] = `
+(JSONSchemaDraft4Element
+  (MemberElement
+    (StringElement)
+    (StringElement))
+  (MemberElement
+    (StringElement)
+    (ArrayElement
+      (LinkDescriptionElement
+        (MemberElement
+          (StringElement)
+          (JSONSchemaDraft4Element))))))
+`;
+
 exports[`given empty value for field additionalItems should replace empty value with semantic element 1`] = `
 (JSONSchemaDraft4Element
   (MemberElement
@@ -43,6 +71,19 @@ exports[`given empty value for field patternProperties should replace empty valu
     (ObjectElement)))
 `;
 
+exports[`given empty value for properties field should replace empty value with semantic element 1`] = `
+(JSONSchemaDraft4Element
+  (MemberElement
+    (StringElement)
+    (StringElement))
+  (MemberElement
+    (StringElement)
+    (ObjectElement
+      (MemberElement
+        (StringElement)
+        (JSONSchemaDraft4Element)))))
+`;
+
 exports[`given empty value instead for properties field keys should replace empty value with semantic element 1`] = `
 (JSONSchemaDraft4Element
   (MemberElement

diff --git a/...es/apidom-ns-json-schema-draft-4/test/refractor/plugins/replace-empty-element/mappings.ts b/...es/apidom-ns-json-schema-draft-4/test/refractor/plugins/replace-empty-element/mappings.ts
@@ -50,7 +50,7 @@ describe('given empty value for field enum', function () {
   });
 });
 
-describe('given empty value instead for properties field keys', function () {
+describe('given empty value for properties field', function () {
   it('should replace empty value with semantic element', async function () {
     const yamlDefinition = dedent`
           $schema: 'http://json-schema.org/draft-04/schema#'
@@ -66,6 +66,38 @@ describe('given empty value instead for properties field keys', function () {
   });
 });
 
+describe('given empty value for LinkDescription.targetSchema field', function () {
+  it('should replace empty value with semantic element', async function () {
+    const yamlDefinition = dedent`
+          $schema: 'http://json-schema.org/draft-04/schema#'
+          links:
+            - targetSchema:
+        `;
+    const apiDOM = await parse(yamlDefinition);
+    const jsonSchemaElement = JSONSchemaElement.refract(apiDOM.result, {
+      plugins: [refractorPluginReplaceEmptyElement()],
+    }) as JSONSchemaElement;
+
+    expect(sexprs(jsonSchemaElement)).toMatchSnapshot();
+  });
+});
+
+describe('given empty value for LinkDescription.schema field', function () {
+  it('should replace empty value with semantic element', async function () {
+    const yamlDefinition = dedent`
+          $schema: 'http://json-schema.org/draft-04/schema#'
+          links:
+            - schema:
+        `;
+    const apiDOM = await parse(yamlDefinition);
+    const jsonSchemaElement = JSONSchemaElement.refract(apiDOM.result, {
+      plugins: [refractorPluginReplaceEmptyElement()],
+    }) as JSONSchemaElement;
+
+    expect(sexprs(jsonSchemaElement)).toMatchSnapshot();
+  });
+});
+
 describe('given JSON Schema definition with no empty values', function () {
   it('should do nothing', async function () {
     const yamlDefinition = dedent`