Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift 5] Fix Issue 10522 : Default parameters in generated model constructors. #785

Merged
merged 1 commit into from
Nov 4, 2020
Merged

[Swift 5] Fix Issue 10522 : Default parameters in generated model constructors. #785

merged 1 commit into from
Nov 4, 2020

Conversation

Tesan3010
Copy link
Contributor

@Tesan3010 Tesan3010 commented Nov 1, 2020 •
edited
Loading

Issue Overview:

  • This PR is targeted to fix the issue #10522.
  • As described in the issue, adding support for default parameters in the auto-generated Swift5 models' constructors.

Fix:

Updating the moustache template by adding nil for the optional parameters in the Swift5 model constructors similar to Swift4 fixed by @deanWombourne's PR.

Cc: @HugoMario

@HugoMario HugoMario mentioned this pull request Nov 4, 2020
Merged
@HugoMario HugoMario merged commit a368967 into swagger-api:master Nov 4, 2020
@HugoMario
Copy link
Contributor

thanks a lot @Tesan3010 !!

@Tesan3010
Copy link
Contributor Author

thanks a lot @Tesan3010 !!

Thanks for reviewing and merging it @HugoMario !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tesan3010 @HugoMario